cpuinfo: Enable for all 32-bit ARM CPUs #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repurpose the ARMv6 cpuinfo for all ARM CPUs. CPU info format likely is not dependent on instruction set version. Signed-off-by: Christian Svensson <[email protected]>
|
This fixes the compilation for ARM 32-bit, but the current parsing code only works for kernels older than v3.8. I think there is value to merging this while the format question is resolved - if nothing else to allow 32-bit ARM to build. WDYT @discordianfish ? |
|
One thing we could do here is to build a set of tests that run on different architectures/kernels. This could be done by adding to the buildkite setup we have for the node_exporter. With buildkite, we run a few different build agents under KVM/QEMU, so we're not dependent on the limited platforms available on CircleCI. |
|
Fixing the parsing itself can be done in another PR, so LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repurpose the ARMv6 cpuinfo for all ARM CPUs. CPU info format likely is
not dependent on instruction set version.
Signed-off-by: Christian Svensson [email protected]
Fixes #291